PhpSpreadsheet/tests/data/Reader/CSV/utf16be.line_break_in_enclo...

<EFBFBD><EFBFBD>Name,Copy,URL
Test,"This is a test
with line breaks
that breaks the
delimiters",http://google.com
Test,"This is a test
with line breaks
that breaks the
delimiters",http://google.com
Test,"This is a test
with line breaks
that breaks the
delimiters",http://google.com
Test,"This is a test
with line breaks
that breaks the
delimiters",http://google.com
Test,"This is a test",http://google.com
-												Improve Coverage for CSV (#1475)

I believe that both CSV Reader and Writer are 100% covered now.

There were some errors uncovered during development.

The reader specifically permits encodings other than UTF-8 to be used.
However, fgetcsv will not properly handle other encodings.
I tried replacing it with fgets/iconv/strgetcsv, but that could not
handle line breaks within a cell, even for UTF-8.
This is, I'm sure, a very rare use case.
I eventually handled it by using php://memory to hold the translated
file contents for non-UTF8. There were no tests for this situation,
and now there are (probably too many).

"Contiguous" read was not handle correctly. There is a file
in samples which uses it. It was designed to read a large sheet,
and split it into three. The first sheet was corrrect, but the
second and third were almost entirely empty. This has been corrected,
and the sample code was adapted into a formal test with assertions
to confirm that it works as designed.

I made a minor documentation change. Unlike HTML, where you never
need a BOM because you can declare the encoding in the file,
a CSV with non-ASCII characters must explicitly include a BOM
for Excel to handle it correctly. This was explained in the Reading CSV
section, but was glossed over in the Writing CSV section, which I
have updated.
											
										
										
											2020-05-17 09:15:18 +00:00
+								<EFBFBD><EFBFBD>Name,Copy,URL
 								Test,"This is a test
 								with line breaks
 								that breaks the
 								delimiters",http://google.com
 								Test,"This is a test
 								with line breaks
 								that breaks the
 								delimiters",http://google.com
 								Test,"This is a test
 								with line breaks
 								that breaks the
 								delimiters",http://google.com
 								Test,"This is a test
 								with line breaks
 								that breaks the
 								delimiters",http://google.com
 								Test,"This is a test",http://google.com