From 20ccfa0d59ba590c12661e74fb97b892e053966e Mon Sep 17 00:00:00 2001 From: Adrien Crivelli Date: Thu, 25 Aug 2016 14:21:52 +0900 Subject: [PATCH] Fix unit tests for MDETERM() --- .../Calculation/MathTrigTest.php | 3 -- tests/data/Calculation/MathTrig/MDETERM.php | 40 +++++++++---------- 2 files changed, 20 insertions(+), 23 deletions(-) diff --git a/tests/PhpSpreadsheetTests/Calculation/MathTrigTest.php b/tests/PhpSpreadsheetTests/Calculation/MathTrigTest.php index 5875f86c..efc48f46 100644 --- a/tests/PhpSpreadsheetTests/Calculation/MathTrigTest.php +++ b/tests/PhpSpreadsheetTests/Calculation/MathTrigTest.php @@ -255,12 +255,9 @@ class MathTrigTest extends \PHPUnit_Framework_TestCase /** * @dataProvider providerMDETERM - * @group fail19 */ public function testMDETERM() { - $this->markTestIncomplete('TODO: This test should be fixed'); - $args = func_get_args(); $expectedResult = array_pop($args); $result = call_user_func_array([MathTrig::class, 'MDETERM'], $args); diff --git a/tests/data/Calculation/MathTrig/MDETERM.php b/tests/data/Calculation/MathTrig/MDETERM.php index e12c4b69..961ebf70 100644 --- a/tests/data/Calculation/MathTrig/MDETERM.php +++ b/tests/data/Calculation/MathTrig/MDETERM.php @@ -19,27 +19,27 @@ return [ 9, ], ], - 6.6613381477509402E-16, + 0, ], [ [ [ - 1.1000000000000001, - 2.2000000000000002, - 3.2999999999999998, + 1.1, + 2.2, + 3.3, ], [ - 4.4000000000000004, + 4.4, 5.5, - 6.5999999999999996, + 6.6, ], [ - 7.7000000000000002, - 8.8000000000000007, - 9.9000000000000004, + 7.7, + 8.8, + 9.9, ], ], - 1.61204383175573E-15, + 0, ], [ [ @@ -59,7 +59,7 @@ return [ 90, ], ], - -4.2632564145606003E-12, + 0, ], [ [ @@ -117,30 +117,30 @@ return [ [ [ [ - 0.20000000000000001, + 0.2, 1, ], [ - 0.34999999999999998, - 10.800000000000001, + 0.35, + 10.8, ], ], - 1.8100000000000001, + 1.81, ], [ [ [ - 0.20000000000000001, + 0.2, 1, - -0.90000000000000002, + -0.9, ], [ - 0.34999999999999998, - 10.800000000000001, + 0.35, + 10.8, 4, ], [ - -3.1499999999999999, + -3.15, 5, null, ],