From 4b0d3c8c1cacfac3bcfbbc65743bd61dba7c21d1 Mon Sep 17 00:00:00 2001 From: Adrien Crivelli Date: Sat, 3 Dec 2016 11:19:22 +0900 Subject: [PATCH] Drop the old `\PHPExcel_Calculation_Functions::VERSION()` This fucntion does not exist in Excel and it is non trivial to implement without svn. Thus it was incorrect for many releases. --- CHANGELOG.md | 2 ++ docs/Functions/Function-list-by-category.md | 1 - docs/Functions/Function-list-by-name.md | 1 - src/PhpSpreadsheet/Calculation.php | 5 ----- src/PhpSpreadsheet/Calculation/Functions.php | 10 ---------- src/PhpSpreadsheet/Calculation/functionlist.txt | 1 - 6 files changed, 2 insertions(+), 18 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 44489b44..b1e0ae98 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -36,6 +36,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/). For a comprehensive list of all class changes, and a semi-automated migration path, read the [migration guide](./docs/Migration-from-PHPExcel.md). +- Dropped `\PHPExcel_Calculation_Functions::VERSION()`. Composer or git should be used to know the version. + ## [1.8.1] - 2015-04-30 ### Bugfixes diff --git a/docs/Functions/Function-list-by-category.md b/docs/Functions/Function-list-by-category.md index 03811811..5561828c 100644 --- a/docs/Functions/Function-list-by-category.md +++ b/docs/Functions/Function-list-by-category.md @@ -179,7 +179,6 @@ ISTEXT | \PhpOffice\PhpSpreadsheet\Calculation\Functions::IS_TEXT N | \PhpOffice\PhpSpreadsheet\Calculation\Functions::N NA | \PhpOffice\PhpSpreadsheet\Calculation\Functions::NA TYPE | \PhpOffice\PhpSpreadsheet\Calculation\Functions::TYPE -VERSION | \PhpOffice\PhpSpreadsheet\Calculation\Functions::VERSION ## CATEGORY_LOGICAL diff --git a/docs/Functions/Function-list-by-name.md b/docs/Functions/Function-list-by-name.md index ab2c1edb..8b7ad958 100644 --- a/docs/Functions/Function-list-by-name.md +++ b/docs/Functions/Function-list-by-name.md @@ -451,7 +451,6 @@ VARA | CATEGORY_STATISTICAL | \PhpOffice\PhpSpreadsheet VARP | CATEGORY_STATISTICAL | \PhpOffice\PhpSpreadsheet\Calculation\Statistical::VARP VARPA | CATEGORY_STATISTICAL | \PhpOffice\PhpSpreadsheet\Calculation\Statistical::VARPA VDB | CATEGORY_FINANCIAL | **Not yet Implemented** -VERSION | CATEGORY_INFORMATION | \PhpOffice\PhpSpreadsheet\Calculation\Functions::VERSION VLOOKUP | CATEGORY_LOOKUP_AND_REFERENCE | \PhpOffice\PhpSpreadsheet\Calculation\LookupRef::VLOOKUP ## W diff --git a/src/PhpSpreadsheet/Calculation.php b/src/PhpSpreadsheet/Calculation.php index f9eb522e..308d84a4 100644 --- a/src/PhpSpreadsheet/Calculation.php +++ b/src/PhpSpreadsheet/Calculation.php @@ -1948,11 +1948,6 @@ class Calculation 'functionCall' => 'Calculation\Categories::DUMMY', 'argumentCount' => '5-7', ], - 'VERSION' => [ - 'category' => Calculation\Categories::CATEGORY_INFORMATION, - 'functionCall' => 'Calculation\Categories::VERSION', - 'argumentCount' => '0', - ], 'VLOOKUP' => [ 'category' => Calculation\Categories::CATEGORY_LOOKUP_AND_REFERENCE, 'functionCall' => '\\PhpOffice\\PhpSpreadsheet\\Calculation\\LookupRef::VLOOKUP', diff --git a/src/PhpSpreadsheet/Calculation/Functions.php b/src/PhpSpreadsheet/Calculation/Functions.php index 9497c8b8..1700598e 100644 --- a/src/PhpSpreadsheet/Calculation/Functions.php +++ b/src/PhpSpreadsheet/Calculation/Functions.php @@ -472,16 +472,6 @@ class Functions return !self::isText($value); } - /** - * VERSION - * - * @return string Version information - */ - public static function VERSION() - { - return 'PhpSpreadsheet ##VERSION##, ##DATE##'; - } - /** * N * diff --git a/src/PhpSpreadsheet/Calculation/functionlist.txt b/src/PhpSpreadsheet/Calculation/functionlist.txt index 67dbd49c..5ac6cf41 100644 --- a/src/PhpSpreadsheet/Calculation/functionlist.txt +++ b/src/PhpSpreadsheet/Calculation/functionlist.txt @@ -335,7 +335,6 @@ VARA VARP VARPA VDB -VERSION VLOOKUP WEEKDAY WEEKNUM