alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Scrutinizer Recommendations 

Two unneeded assignments in tests, one unused parameter in source code.
This commit is contained in:
Owen Leibman 2020-06-25 23:11:30 -07:00
parent 6080c4561d
commit 752a0a5a6c
2 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/PhpSpreadsheet/Reader/Html.php
View File

@ -506,7 +506,7 @@ class Html extends BaseReader
if ($child->nodeName !== 'td' && $child->nodeName !== 'th') { if ($child->nodeName !== 'td' && $child->nodeName !== 'th') {
$this->processDomElement($child, $sheet, $row, $column, $cellContent); $this->processDomElement($child, $sheet, $row, $column, $cellContent);
} else { } else {
$this->processDomElementThTd($element, $sheet, $row, $column, $cellContent, $child, $attributeArray); $this->processDomElementThTd($sheet, $row, $column, $cellContent, $child, $attributeArray);
} }
} }
@ -559,7 +559,7 @@ class Html extends BaseReader
} }
} }
private function processDomElementThTd(DOMNode $element, Worksheet $sheet, int &$row, string &$column, string &$cellContent, DOMElement $child, array &$attributeArray): void private function processDomElementThTd(Worksheet $sheet, int &$row, string &$column, string &$cellContent, DOMElement $child, array &$attributeArray): void
{ {
while (isset($this->rowspan[$column . $row])) { while (isset($this->rowspan[$column . $row])) {
++$column; ++$column;

4
tests/PhpSpreadsheetTests/Reader/Html/HtmlTest.php
View File

@ -23,7 +23,7 @@ class HtmlTest extends TestCase
$filename = 'tests/data/Reader/HTML/badhtml.html'; $filename = 'tests/data/Reader/HTML/badhtml.html';
$reader = new Html(); $reader = new Html();
self::assertTrue($reader->canRead($filename)); self::assertTrue($reader->canRead($filename));
$spreadsheet = $reader->load($filename); $reader->load($filename);
self::assertTrue(false); self::assertTrue(false);
} }
@ -33,7 +33,7 @@ class HtmlTest extends TestCase
$filename = __FILE__; $filename = __FILE__;
$reader = new Html(); $reader = new Html();
self::assertFalse($reader->canRead($filename)); self::assertFalse($reader->canRead($filename));
$spreadsheet = $reader->load($filename); $reader->load($filename);
self::assertTrue(false); self::assertTrue(false);
} }