alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Throw exception in XLS with columns or rows overflow (#138) 

This is a hard limit of the BIFF format that cannot be worked around,
so it is best to throw exceptions than silently discard data or generate
corrupted files.
This commit is contained in:
simivar 2017-04-14 13:45:53 +02:00 committed by Adrien Crivelli
parent bd9eb19593
commit 8fd1825d39
1 changed files with 2 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/PhpSpreadsheet/Writer/Xls/Worksheet.php
View File

@ -287,8 +287,6 @@ class Worksheet extends BIFFwriter
{ {
$phpSheet = $this->phpSheet; $phpSheet = $this->phpSheet;
$num_sheets = $phpSheet->getParent()->getSheetCount();
// Write BOF record // Write BOF record
$this->storeBof(0x0010); $this->storeBof(0x0010);
@ -405,9 +403,9 @@ class Worksheet extends BIFFwriter
$row = $cell->getRow() - 1; $row = $cell->getRow() - 1;
$column = \PhpOffice\PhpSpreadsheet\Cell::columnIndexFromString($cell->getColumn()) - 1; $column = \PhpOffice\PhpSpreadsheet\Cell::columnIndexFromString($cell->getColumn()) - 1;
// Don't break Excel! // Don't break Excel break the code!
if ($row > 65535 || $column > 255) { if ($row > 65535 || $column > 255) {
break; throw new \PhpOffice\PhpSpreadsheet\Writer\Exception('Rows or columns overflow! Excel5 has limit to 65535 rows and 255 columns. Use XLSX instead.');
} }
// Write cell value // Write cell value