Still test against 5.6, but with allowed failures, and skip tests explicitly for features that require PHP >= 7.0.0

This commit is contained in:
MarkBaker 2019-05-30 12:11:49 +02:00
parent 561852e341
commit 9ba96efc97
2 changed files with 3 additions and 2 deletions

View File

@ -7,8 +7,6 @@ and this project adheres to [Semantic Versioning](https://semver.org).
## [Unreleased] ## [Unreleased]
- **Minimum version of PHP for the next release is now 7.0.0**
### Added ### Added
- Added support for the SWITCH function - [Issue #963](https://github.com/PHPOffice/PhpSpreadsheet/issues/963) and [PR #983](https://github.com/PHPOffice/PhpSpreadsheet/pull/983) - Added support for the SWITCH function - [Issue #963](https://github.com/PHPOffice/PhpSpreadsheet/issues/963) and [PR #983](https://github.com/PHPOffice/PhpSpreadsheet/pull/983)

View File

@ -39,6 +39,9 @@ class XlsxTest extends TestCase
*/ */
public function testLoadXlsxWithDoubleAttrDrawing() public function testLoadXlsxWithDoubleAttrDrawing()
{ {
if (version_compare(PHP_VERSION, '7.0.0', '<')) {
$this->markTestSkipped('Only handled in PHP version >= 7.0.0');
}
$filename = './data/Reader/XLSX/double_attr_drawing.xlsx'; $filename = './data/Reader/XLSX/double_attr_drawing.xlsx';
$reader = new Xlsx(); $reader = new Xlsx();
$reader->load($filename); $reader->load($filename);