Merge pull request #432 from driebit/fix-undefined-offset
Improve sheet index error handling
This commit is contained in:
commit
b56bcb980b
|
@ -461,10 +461,12 @@ class PHPExcel
|
|||
* Get active sheet
|
||||
*
|
||||
* @return PHPExcel_Worksheet
|
||||
*
|
||||
* @throws PHPExcel_Exception
|
||||
*/
|
||||
public function getActiveSheet()
|
||||
{
|
||||
return $this->_workSheetCollection[$this->_activeSheetIndex];
|
||||
return $this->getSheet($this->_activeSheetIndex);
|
||||
}
|
||||
|
||||
/**
|
||||
|
@ -570,16 +572,14 @@ class PHPExcel
|
|||
*/
|
||||
public function getSheet($pIndex = 0)
|
||||
{
|
||||
|
||||
$numSheets = count($this->_workSheetCollection);
|
||||
|
||||
if ($pIndex > $numSheets - 1) {
|
||||
if (!isset($this->_workSheetCollection[$pIndex])) {
|
||||
$numSheets = $this->getSheetCount();
|
||||
throw new PHPExcel_Exception(
|
||||
"Your requested sheet index: {$pIndex} is out of bounds. The actual number of sheets is {$numSheets}."
|
||||
);
|
||||
} else {
|
||||
return $this->_workSheetCollection[$pIndex];
|
||||
}
|
||||
|
||||
return $this->_workSheetCollection[$pIndex];
|
||||
}
|
||||
|
||||
/**
|
||||
|
|
Loading…
Reference in New Issue