From de7758f9b6b402397c9202fb2570f6077448c706 Mon Sep 17 00:00:00 2001 From: Adrien Crivelli Date: Thu, 1 Feb 2018 21:23:36 +0900 Subject: [PATCH] Avoid potentially unsupported PSR-16 cache keys Ensure compatibility with all PSR-16 cache implementation by using a stricter character set for cache key that match the spec. Fixes #354 --- CHANGELOG.md | 6 ++++++ src/PhpSpreadsheet/Collection/Cells.php | 2 +- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 750a196c..6dc867a2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -5,6 +5,12 @@ All notable changes to this project will be documented in this file. The format is based on [Keep a Changelog](http://keepachangelog.com/) and this project adheres to [Semantic Versioning](http://semver.org/). +## [Unreleased] + +### Fixed + +- Avoid potentially unsupported PSR-16 cache keys - [#354](https://github.com/PHPOffice/PhpSpreadsheet/issues/354) + ## [1.1.0] - 2018-01-28 ### Added diff --git a/src/PhpSpreadsheet/Collection/Cells.php b/src/PhpSpreadsheet/Collection/Cells.php index 561f6a4d..ac5faf04 100644 --- a/src/PhpSpreadsheet/Collection/Cells.php +++ b/src/PhpSpreadsheet/Collection/Cells.php @@ -285,7 +285,7 @@ class Cells */ private function getUniqueID() { - return uniqid('phpspreadsheet-', true) . '-'; + return uniqid('phpspreadsheet.', true) . '.'; } /**