alex
/
PhpSpreadsheet
1
0
Fork 0
Code Issues Pull Requests Releases Wiki Activity

Scrutinizer resolutions (#1032) 

* list($ac, $ar) = sscanf($a, '%[A-Z]%d'); to appease scrutinizer, which complains about ($a, '%[A-Z]%d')

* Fix a docblock error

* More scrutinizer happiness
This commit is contained in:
Mark Baker 2019-06-23 22:13:49 +02:00 committed by GitHub
parent 591f1e0c70
commit e884271dc2
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
6 changed files with 19 additions and 19 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
src/PhpSpreadsheet/Calculation/Calculation.php
View File

@ -117,7 +117,7 @@ class Calculation
/**
* An array of the nested cell references accessed by the calculation engine, used for the debug log.
*
* @var array of string
* @var CyclicReferenceStack
*/
private $cyclicReferenceStack;

4
src/PhpSpreadsheet/Chart/Axis.php
View File

@ -365,10 +365,10 @@ class Axis extends Properties
}
/**
* Set Shadow Properties from Maped Values.
* Set Shadow Properties from Mapped Values.
*
* @param array $properties_map
* @param * $reference
* @param mixed &$reference
*
* @return Axis
*/

4
src/PhpSpreadsheet/Chart/GridLines.php
View File

@ -319,7 +319,7 @@ class GridLines extends Properties
* Set Shadow Properties Values.
*
* @param array $properties_map
* @param * $reference
* @param mixed &$reference
*
* @return GridLines
*/
@ -439,7 +439,7 @@ class GridLines extends Properties
{
if ($size !== null) {
$this->activateObject();
$softEdges['size'] = (string) $this->getExcelPointsWidth($size);
$this->softEdges['size'] = (string) $this->getExcelPointsWidth($size);
}
}

16
src/PhpSpreadsheet/Chart/Layout.php
View File

@ -175,13 +175,13 @@ class Layout
/**
* Set X-Mode.
*
* @param X-Mode $value
* @param string $value
*
* @return Layout
*/
public function setXMode($value)
{
$this->xMode = $value;
$this->xMode = (string) $value;
return $this;
}
@ -199,13 +199,13 @@ class Layout
/**
* Set Y-Mode.
*
* @param Y-Mode $value
* @param string $value
*
* @return Layout
*/
public function setYMode($value)
{
$this->yMode = $value;
$this->yMode = (string) $value;
return $this;
}
@ -223,13 +223,13 @@ class Layout
/**
* Set X-Position.
*
* @param X-Position $value
* @param float $value
*
* @return Layout
*/
public function setXPosition($value)
{
$this->xPos = $value;
$this->xPos = (float) $value;
return $this;
}
@ -247,13 +247,13 @@ class Layout
/**
* Set Y-Position.
*
* @param Y-Position $value
* @param float $value
*
* @return Layout
*/
public function setYPosition($value)
{
$this->yPos = $value;
$this->yPos = (float) $value;
return $this;
}

4
src/PhpSpreadsheet/Worksheet/Dimension.php
View File

@ -64,7 +64,7 @@ abstract class Dimension
*/
public function setVisible($pValue)
{
$this->visible = $pValue;
$this->visible = (bool) $pValue;
return $this;
}
@ -119,7 +119,7 @@ abstract class Dimension
*/
public function setCollapsed($pValue)
{
$this->collapsed = $pValue;
$this->collapsed = (bool) $pValue;
return $this;
}

8
src/PhpSpreadsheet/Writer/Xlsx/Worksheet.php
View File

@ -383,7 +383,7 @@ class Worksheet extends WriterPart
}
// Column visibility
if ($colDimension->getVisible() == false) {
if ($colDimension->getVisible() === false) {
$objWriter->writeAttribute('hidden', 'true');
}
@ -398,7 +398,7 @@ class Worksheet extends WriterPart
}
// Collapsed
if ($colDimension->getCollapsed() == true) {
if ($colDimension->getCollapsed() === true) {
$objWriter->writeAttribute('collapsed', 'true');
}
@ -995,12 +995,12 @@ class Worksheet extends WriterPart
}
// Row visibility
if (!$rowDimension->getVisible()) {
if (!$rowDimension->getVisible() === true) {
$objWriter->writeAttribute('hidden', 'true');
}
// Collapsed
if ($rowDimension->getCollapsed()) {
if ($rowDimension->getCollapsed() === true) {
$objWriter->writeAttribute('collapsed', 'true');
}