Commit Graph

2426 Commits

Author SHA1 Message Date
Adrien Crivelli 395b750030
Stricter visibility 2020-07-19 12:30:31 +09:00
Adrien Crivelli c3fa31de13
Missing typing 2020-07-19 12:21:40 +09:00
Adrien Crivelli 7cb4884b96
WEBSERVICE is HTTP client agnostic
HTTP client must be configured via `Settings::setHttpClient()`. This is
a small breaking change, but only for the very few people who started using
WEBSERVICE from last version.

Fixes #1562
Closes #1568
2020-07-19 11:33:01 +09:00
oleibman 165034ad70
Restoring State After Static Changes in Tests (#1571)
This request does not change any source code, only tests.

For a change on which I was working, a test passed when run on its own,
but failed when run as part of the full test suite. It turned out that
an existing test had changed a static value,
thousands separator in this case, and failed to restore it.
The test turned out to be AdvancedBinderTest.

The search for the offending test was more difficult than it should have
been because 26 test scripts which had nothing to do with thousands
separator nevertheless changed that value. They all changed
decimal separator, currency code, and compatibility mode as well,
again for no reason. I changed all of those to eliminate those operations.

I changed the following tests, which actually do change the static
properties identified above for a reason, to restore them as part of teardown.
- CalculationTest sets compatibilityMode and locale
- DayTest sets compatibilityMode, returnDateType, and excelCalendar
- CountTest sets compatibilityMode
- FunctionsTest sets compatibilityMode and returnDateType
- AdvancedValueBinderTest sets currencyCode, decimalSeparator, thousandsSeparator
- StringHelperTest sets currencyCode, decimalSeparator, thousandsSeparator
- NumberFormatTest sets currencyCode, decimalSeparator, thousandsSeparator
- HtmlNumberFormatTest sets currencyCode, decimalSeparator, thousandsSeparator
2020-07-15 13:23:00 +02:00
Mark Baker b89968d206
Additional Unit Tests (#1582) 2020-07-14 10:58:50 +02:00
MarkBaker 47eb3e9f12 Update Change Log 2020-07-05 21:05:21 +02:00
MarkBaker d4094c0b58 Minor refactoring 2020-07-05 20:43:59 +02:00
MarkBaker c6de56e4cf Minor refactoring 2020-07-05 20:21:54 +02:00
MarkBaker f3fc321177 Gah! Using PHPStorm refactor changes the formatting, so valid code suddenly triggers in phpcs 2020-07-05 18:32:40 +02:00
MarkBaker 6cbb622a9e Minor refactoring 2020-07-05 18:25:39 +02:00
MarkBaker 586b36b440 Refactor Xml PageSettings into a separate loader class 2020-07-05 18:11:14 +02:00
MarkBaker 961dc693d1 Improve SCrutinizer happiness 2020-07-05 17:35:13 +02:00
MarkBaker cf6769eab1 Hopefully a final phpcs fix before I start looking at how to run a pre-commit hook on Windows 10 2020-07-05 17:17:56 +02:00
MarkBaker e89196f65b phpcs fixes, although I thought I'd successfully added the pre-commit hook to pick those up before the commit, guess the problem is running from Windoze, so I'll have to address that 2020-07-05 17:05:44 +02:00
MarkBaker 3997dcc3af Not sure why PHP 7.4 should suddenly have decided to report a notice in a totally unrelated part of the Xml Reader 2020-07-05 16:39:47 +02:00
MarkBaker d009347e25 Forgot to check in the test files for the unit tests 2020-07-05 16:28:46 +02:00
MarkBaker 8629337101 Retrieving print/page setup for the Xml Reader 2020-07-05 16:22:35 +02:00
MarkBaker 84ba21400c Fix datatype conversion for Gnumeric values 2020-07-04 00:28:16 +02:00
MarkBaker aecef1372f Read Ods Margins 2020-07-03 19:26:57 +02:00
MarkBaker c288c11d01 Failed to avoid the void trap 2020-07-01 20:06:36 +02:00
MarkBaker e644cc72d0 Additional print information for Gnumeric 2020-07-01 19:55:25 +02:00
MarkBaker 163da06505 Horizontal an dVertical centering for the Ods Reader 2020-07-01 14:50:13 +02:00
MarkBaker 736d9ffd3b Gotta keep phpcs happy, even if it is only a blank line between property declarations 2020-06-30 22:45:08 +02:00
MarkBaker 4dadf4a5c8 Refactor reading Ods Page Settings into a separate class 2020-06-30 22:23:33 +02:00
MarkBaker 13a3363410 Return void, just to keep phpcs happy 2020-06-30 19:15:08 +02:00
MarkBaker 3780072ae9 Retrieve basic print settings in the Ods Reader 2020-06-30 19:07:56 +02:00
MarkBaker 1f865c84c0 Keep phpcs happy 2020-06-30 07:24:12 +02:00
MarkBaker fbb04c1f82 Xls Writer changes to save print order 2020-06-30 07:01:51 +02:00
MarkBaker 4060cdec7e Fix comment 2020-06-30 01:11:53 +02:00
MarkBaker 362b18ca12 Read Print Settings Page Order in Xls Reader
And eliminate switch for simple boolean portrait/landscape option
2020-06-30 00:53:10 +02:00
MarkBaker 21b34f0afb pageOrder is nullable 2020-06-29 20:27:47 +02:00
MarkBaker a0bba38281 Support pageOrder in page setup for Xlsx Reader and Writer 2020-06-29 20:15:41 +02:00
Adrien Crivelli 8712fb0424
Drop polyfill that are not needed since PHP 7.2 2020-06-29 11:28:05 +09:00
Adrien Crivelli 39f1a61120
CHANGELOG placeholder 2020-06-29 10:52:54 +09:00
Adrien Crivelli 73fe58fdc9
1.14.0 2020-06-29 10:51:21 +09:00
Adrien Crivelli 96e493ca51
Update CHANGELOG 2020-06-29 10:23:33 +09:00
paulkned 7f23ccb69d
Added support for the WEBSERVICE function (#1409)
Co-authored-by: Paul Kievits <kievits@rsm.nl>
2020-06-29 10:17:58 +09:00
Adrien Crivelli e74ef3a802
Generate API doc on tag only
Because it doesn't need to be run on every PR and documenting
only release is exactly what we want
2020-06-29 10:15:42 +09:00
Pavel Alazankin 6caa0cb4f5
add ability to set codepage explicitly for BIFF5 (#1484)
If BIFF5 excel 95 file doesn't have codepage record, the default codepage CP1252 is used and can't be change.
That causes to problems with decoding cyrillic text.
2020-06-28 23:39:38 +09:00
Adrien Crivelli 93fbf8a938
Update CHANGELOG 2020-06-28 22:03:37 +09:00
Adrien Crivelli f1fb8dcf1f
Don't ouput row and columns without any cells in HTML writer
If row or column dimensions are accessed, then HTML writer would
still generate lots of empty cells, to show nothing at all. This
now ignore row and column dimensions to only output cell that
actually exists (even if those cells are empty).

Fixes #1235
Close #1537
2020-06-28 22:03:37 +09:00
Adrien Crivelli a90bf863ab
Merge pull request #1499 from oleibman/htmledit
Add ability to save edited Html/Pdf
2020-06-28 17:46:56 +09:00
Adrien Crivelli 14a0fa4cd0
New members should always be private 2020-06-28 17:35:10 +09:00
Adrien Crivelli 5e64479c06
Document the callback 2020-06-28 17:34:50 +09:00
Adrien Crivelli 2896e6ceb9
Consistent regexp escaping 2020-06-28 17:34:32 +09:00
Adrien Crivelli 321dfc7a3d
Upgrad PHP deps 2020-06-28 16:29:13 +09:00
MarkBaker 65a94abeca And now phpcs is telling me to fix my grammar 2020-06-27 23:10:28 +02:00
Mark Baker a264cafe4c
Helper class for the conversion of cell addresses between A1 and R1C1 formats, and vice-versa (#1558)
* Helper class for the conversion of cell addresses between A1 and R1C1 formats, and vice-versa
2020-06-27 23:03:25 +02:00
Owen Leibman 9f1a33cc8a Scrutinizer Again
Cascading series of unused unused parameters.
2020-06-25 23:39:28 -07:00
Owen Leibman 752a0a5a6c Scrutinizer Recommendations
Two unneeded assignments in tests, one unused parameter in source code.
2020-06-25 23:11:30 -07:00