PhpSpreadsheet

alex

PhpSpreadsheet

Fork 0

Commit Graph

Author	SHA1	Message	Date
Adrien Crivelli	8d76020590	Consistent `stringFromColumnIndex()` and `columnIndexFromString()` Column indexes are always based on 1 everywhere in PhpSpreadsheet. This is consistent with rows starting at 1, as well as Excel function `COLUMN()`. It should also make it easier to reason about columns and rows and remove any doubts whether a specific method is expecting 0 based or 1 based indexes. Fixes #273 Fixes https://github.com/PHPOffice/PHPExcel/issues/307 Fixes https://github.com/PHPOffice/PHPExcel/issues/476	2017-11-26 15:29:08 +09:00
Adrien Crivelli	8dddf56c2e	Use proper syntax for variadic functions This simplify code, increase readability and improve the function signature for API users.	2017-01-23 15:01:20 +09:00
Adrien Crivelli	e1f81f0fe0	Refactor tests data from custom format to PHP FIX #14	2016-08-16 21:00:19 +09:00

Author

SHA1

Message

Date

Adrien Crivelli

8d76020590

Consistent `stringFromColumnIndex()` and `columnIndexFromString()`

Column indexes are always based on 1 everywhere in PhpSpreadsheet.
This is consistent with rows starting at 1, as well as Excel
function `COLUMN()`. It should also make it easier to reason about
columns and rows and remove any doubts whether a specific method is
expecting 0 based or 1 based indexes.

Fixes #273
Fixes https://github.com/PHPOffice/PHPExcel/issues/307
Fixes https://github.com/PHPOffice/PHPExcel/issues/476

2017-11-26 15:29:08 +09:00

Adrien Crivelli

8dddf56c2e

Use proper syntax for variadic functions

This simplify code, increase readability and improve the function
signature for API users.

2017-01-23 15:01:20 +09:00

Adrien Crivelli

e1f81f0fe0

Refactor tests data from custom format to PHP

FIX #14

2016-08-16 21:00:19 +09:00

3 Commits