Commit Graph

221 Commits

Author SHA1 Message Date
Mingc
a1a03428e7 Decode comment text in xls reader (#99) (#100)
Previously, xls reader did not decode comment properly if they used UTF-8.

References:

* [The Microsoft Excel File Format](https://www.openoffice.org/sc/excelfileformat.pdf): From BIFF8 on, strings are always stored using UTF-16LE text encoding. The character array is a sequence of 16-bit values. Additionally it is possible to use a compressed format, which omits the high bytes of all characters, if they are all zero
* [Apache POI](http://grepcode.com/file/repo1.maven.org/maven2/org.apache.poi/poi/3.7/org/apache/poi/util/StringUtil.java#StringUtil.readUnicodeString%28org.apache.poi.util.LittleEndianInput%29): is16BitFlag
2017-02-23 11:42:52 +09:00
Adrien Crivelli
7b90bb9394
Drop checks for mbstring existence
Since mbstring is now a hard dependency enforced by composer, it is
no longer necessary to check for its presence and implement fallbacks.
2017-02-16 11:56:22 +09:00
Adrien Crivelli
1a52e23f08
Remove obsolete math polyfills 2017-02-16 11:15:22 +09:00
Adrien Crivelli
4ae95e5f7c
Drop obsolete method check existence 2017-02-16 11:01:35 +09:00
Adrien Crivelli
ce8ba1fa66
Drop obsolete PHP 5.2 specific code 2017-02-16 10:42:54 +09:00
Alex Milde
47d7260c43 Ignore images with missing data when reading xlsx
Ignore images with missing data when reading xlsx

Fixes #94, closes #95
2017-02-16 09:42:07 +09:00
Roland Häder
99e5a8e919
Use isset() instead of in_array() for increased performance and code simplification
Closes #82

Signed-off-by: Roland Häder <roland@mxchange.org>
2017-02-14 23:06:35 +09:00
Adrien Crivelli
6e247c30d9
Drop support for SQLite 2 because it does not exist in PHP 5.6+ anymore 2017-02-14 12:53:20 +09:00
Zharikov Viktor
de5a04e4cb
Avoid adding an unnecessary extra cell at the end of table when writing to HTML
Fixes #91, and closes #84
2017-02-14 11:57:29 +09:00
Tony Brix
149f9e649b fill color will change startColor and endColor (#90) 2017-02-10 21:03:17 +09:00
Adrien Crivelli
fe73b2d402
Drop PHPSPREADSHEET_ROOT constant 2017-01-23 15:35:10 +09:00
Adrien Crivelli
8dddf56c2e
Use proper syntax for variadic functions
This simplify code, increase readability and improve the function
signature for API users.
2017-01-23 15:01:20 +09:00
Adrien Crivelli
152d39bd42
Unalign docblock
Because alignment was all broken and becaues it doesn't improve much
the code readability, but potentially create more complicated diff, we
prefer to unlaign all docblocks.
2017-01-23 11:25:02 +09:00
Adrien Crivelli
031af1e9d2
Standardize writers and readers name to be the format most common extension in CamelCase 2017-01-22 17:39:23 +09:00
Adrien Crivelli
1cdc8531b8
Rename writer PDF to Pdf for consistency 2017-01-22 00:58:48 +09:00
Adrien Crivelli
035281f04c
Basic test covering of all PDF writers
Third party PDF libraries must now be installed via composer and naturally
via composer autoloading mechanism. Because of that it is not necessary
to specify their path on disk. The usage is simplified and it allows us
to include them in our unit tests.

This also means that from now on PhpSpreadsheet must use composer autoloader
mechanism. The internal autoloading implementation was dropped.
2017-01-22 00:49:44 +09:00
titanrat
66f37218c9 Fix mpdf writer to work with MPDF 6.1.3 (#76)
Fix old namespace. New writer tested with MPDF 6.1.3
2017-01-19 18:26:27 +09:00
Сергей Симонян
2aa7707826 Use use sections instead of fully qualified class names (#69) 2017-01-10 02:09:39 +09:00
Adrien Crivelli
1b0b609c30
Remove dead code 2017-01-05 12:29:30 +09:00
Adrien Crivelli
ec928d393f
Fix indentation as suggested by Scrunitizer 2017-01-05 12:26:20 +09:00
Adrien Crivelli
e9d03cc6d3
Apply Scrutinzer patches for spacing 2017-01-05 12:14:44 +09:00
Adrien Crivelli
c8a69dfb54
Fix comment #65 2017-01-05 11:11:18 +09:00
Roland Häder
3723bb825b Added Row::getWorksheet() to expose row's bounded worksheet #59, #60 2017-01-05 11:05:49 +09:00
Christian Schmidt
61408fc691 Properly format non-integer font sizes (#66)
The OOXML spec defines the font sizes (the `sz` element) as a double, so the value needs to be wrapped in `PHPExcel_Shared_String::FormatNumber()` to avoid breaking in non-English locales.
2017-01-04 17:27:42 +09:00
Adrien Crivelli
0c75d64817
Remove unused variables 2016-12-26 14:36:47 +09:00
Adrien Crivelli
8ce610eb59
Use correct declared debugLog 2016-12-26 13:59:31 +09:00
Adrien Crivelli
56245d558e
Use ::class notation as much as possible
```
               *             ,
                           _/^\_
                          <     >
         *                 /.-.\         *
                  *        `/&\`                   *
                          ,@.*;@,
                         /_o.I %_\    *
            *           (`'--:o(_@;
                       /`;--.,__ `')             *
                      ;@`o % O,*`'`&\
                *    (`'--)_@ ;o %'()\      *
                     /`;--._`''--._O'@;
                    /&*,()~o`;-.,_ `""`)
         *          /`,@ ;+& () o*`;-';\
                   (`""--.,_0 +% @' &()\
                   /-.,_    ``''--....-'`)  *
              *    /@%;o`:;'--,.__   __.'\
                  ;*,&(); @ % &^;~`"`o;@();         *
                  /(); o^~; & ().o@*&`;&%O\
            jgs   `"="==""==,,,.,="=="==="`
               __.----.(\-''#####---...___...-----._
             '`         \)_`"""""`
                     .--' ')
                   o(  )_-\
                     `"""` `
```
2016-12-26 13:21:12 +09:00
Roman Kravchuk
a045a446d5 fix namespace for ReflectionObject class
PHP Fatal error:  Class 'PhpOffice\PhpSpreadsheet\Writer\ReflectionObject' not found in PhpSpreadsheet/src/PhpSpreadsheet/Writer/Ods.php on line 151
2016-12-26 12:27:40 +09:00
John Doe
a39d71ec16
Fix attaching drawing for xls
FIX #53, #61
2016-12-26 12:20:59 +09:00
Adrien Crivelli
af82e266c0
A few more manual code style fixes for phpcs 2016-12-23 00:08:55 +09:00
Adrien Crivelli
8c66afe39a
Upgrade to PHP-CS-Fixer 2.0 2016-12-22 23:46:26 +09:00
Adrien Crivelli
0de994c998
Fix IMSQRT() tests on PHP 7.1 2016-12-22 22:54:58 +09:00
MarkBaker
03f96ab6d8 GH-57 Bug fix in Border.php 2016-12-18 23:06:10 +00:00
Arthur-min
a5c21a7b43 Exxcel 2003 XML working pattern property (#54) 2016-12-14 22:21:16 +09:00
Enyby
30a5e4b893
Fixed bug on load XML with column filter
`continue;` break columnID increment. Another problem can be on Merged cells.
2016-12-14 22:03:21 +09:00
DCoderLT
2484a03f19
Fix fatal error when RichText extract container cell's font
`RichText` tries to extract container cell's font via
`Cell->getParent()->getStyle(...)`, which crashes because
`getParent()` does not return a worksheet. Changing it to
`getWorksheet()` fixes the problem.
2016-12-14 21:56:57 +09:00
jacobsreynolds
720fb3eff5
Read background color of cells from HTML file
If a <td> in HTML has a bgcolor attribute, it is then applied to the spreadsheet file
2016-12-14 21:40:59 +09:00
Arthur Miniconi
ab7aa68300
Excel2003 XML parse Interior Pattern property 2016-12-14 21:29:36 +09:00
golodnyi
a6a709a4ba Not relevant parameters when calling functions 2016-12-09 12:33:41 +09:00
Adrien Crivelli
c8a8fd2610
Stricter check whether file exists before reading
This should avoid issues when user submit a non-existing filename
that is wrongly identified as CSV.

Typically https://github.com/PHPOffice/PHPExcel/issues/1076 and
https://github.com/PHPOffice/PHPExcel/issues/1078 could have been
avoided.
2016-12-09 00:15:22 +09:00
golodnyi
5e03e282e5
Duplicate case in switch 2016-12-08 19:22:58 +09:00
mattkibbler
62345ef4da
Allow start and end date of DATEDIF function to be the same 2016-12-04 19:04:10 +09:00
Nikolay Ninkov
a7155d8890
Partial localization of functions in Bulgarian 2016-12-04 18:48:21 +09:00
Adrien Crivelli
3bd0f6f985
Fix autofilter cloning across PHP versions
Avoid indirect access variable ambiguity across PHP 5.6 and PHP 7.0
2016-12-04 16:44:40 +09:00
Matthias Van Woensel
39b8dbd0a1
Adding float cast to MOD function
If $a or $b are not strings, you can get an error that fmod needs param 1 ($a) to be of type double.
MS Excel does not fall over when you insert an empty string in MOD, so I'm guessing PHPExcel should do the same?
2016-12-04 16:12:51 +09:00
Gemorroj
48a6e86adc
Added missing variables 2016-12-04 15:58:21 +09:00
Herman M. Hofman
b964788d5c
FIX PHP Fatal Error on an invalid Blip Field.
For (still) unknown reasons, PHPExcel detects a wrong field type.
If there is no BSE Index, we will fail here and other fields are not read.
So if the BSE Index < 1, continue with the next field.
TODO: Why is there no BSE Index?
      Is this a new Office Version?
      Password protected field?
      More likely : a uncompatible picture

PHP Notice:  Undefined offset: -1 in Classes/PHPExcel/Reader/Excel5.php on line 1063
PHP Fatal error:  Call to a member function getBlipType() on a non-object in Classes/PHPExcel/Reader/Excel5.php on line 1064
2016-12-04 15:47:20 +09:00
josch1710
c1f5bdba5d
removeColumn doesn't remove all cells
removeColumn doesn't remove all cells, because CacheBase::deleteCacheData only unsets cell data if they are objects.
But cached cell data could be arrays.
I moved the unset from inside the if block (line 150 ff) to after the if block.
2016-12-04 15:33:47 +09:00
appelflap
3b4f54722f
Also check Library Path
LibraryName was being checked twice.
2016-12-04 15:28:50 +09:00
Adrien Crivelli
6d44884e19
Drop deprecated methods #22 2016-12-04 15:06:31 +09:00